List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:May 25 2009 5:07pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (staale.smedseng:2910)
Bug#44736
View as plain text  
Hi Staale,

OK to push. One minor comment below.

On 5/25/09 1:21 PM, Staale Smedseng wrote:
> #At file:///export/home/tmp/ss156133/z/44736-51/ based on
> revid:davi.arnaut@stripped
>
>   2910 Staale Smedseng	2009-05-25
>        Bug #44736 mysqld_safe's my_which() is broken and
>        doesn't find 'logger'
>
>        Due to a variable quoting mistake, the $PATH environment
>        variable isn't parsed correctly when searching for the
>        existence of the desired executable(s) (logger in this
>        case).
>
>        This patch removes the quotes.
>

Could you perhaps add in the changeset comment that the problem is that 
use of double quotes prevents word splitting ($IFS)?

Thanks

-- Davi Arnaut
Thread
bzr commit into mysql-5.1-bugteam branch (staale.smedseng:2910) Bug#44736Staale Smedseng25 May
  • Re: bzr commit into mysql-5.1-bugteam branch (staale.smedseng:2910)Bug#44736Davi Arnaut25 May