Hi Luis,
Luís Soares wrote:
> Hi Zhenxing,
> Let me start by commenting on the behavior:
>
> 1. The BEGIN/COMMIT/ROLLBACK, will no longer be prepended with
> "use ...; " since this is explicitly suppressed when building
> the query log event.
>
> 2. DB filtering rules will not apply anymore to the
> BEGIN/COMMIT/ROLLBACK statements.
>
correct, actually 1) is not very necessary to this bug, but since we are
doing 2), then it would be very confusing if we still prepend "use ..."
for these statements. And I also think this will not affect users.
> Given 1. and 2. I started thinking on how this could impact the
> existing users, and have not been able to come up with anything
> against. I feel that, in a way, this is a difference in behavior
> with respect to binlogging that has direct impact on filtering
> rules.
>
I have thought about the possible impact introduced by this change too,
and the worse I can think of is an extra empty transaction. So I think
the risk of this change should be low.
> Punch line: I agree with your fix.
>
:) That's a good one!
> However, there are some issues still with the proposed patch. I have
> run mtr on the patched binary mysqld and there are some tests
> failing because some result files are left unchanged. These are, as
> expected, related to binlog. Please fix them:
>
> * binlog
> * mix_innodb_myisam_binlog
>
> Please, find some comments inline also.
>
Thank you! I'll fix those.
[snip]
