Chuck,
Patch approved.
Chuck Bell wrote:
> #At file:///D:/source/bzr/mysql-6.0-bug-35585/ based on
> revid:charles.bell@stripped
>
> 2810 Chuck Bell 2009-05-13
> BUG#35585 : Online backup: Apparent synonyms for binlog start_position
>
> There are synonyms used in the backup code, tests, and logs
> that refer to the binlog start position as 'binlog_pos'. This
> is confusing and should be changed to match the documentation
> and general practice of replication and binary logs.
>
> This patch changes the backup code, tests, and logs such that
> all 'backup_pos[..]' that reference the binlog start position
> have been changed to 'backup_start_pos' and where 'binlog_pos'
> is used to refer to both the binlog file and binlog start
> position have been changed to 'binlog_info'.
> modified:
> client/backup_stream.c
> client/mysqlbackup.cc
> mysql-test/suite/backup/r/backup.result
> mysql-test/suite/backup/r/backup_logs.result
> mysql-test/suite/backup/t/backup.test
> mysql-test/suite/backup_ptr/r/backup_ptr_commits.result
> mysql-test/suite/backup_ptr/t/backup_ptr.test
> mysql-test/suite/backup_ptr/t/backup_ptr_commits.test
> mysql-test/suite/backup_ptr/t/backup_ptr_objects.test
> mysql-test/suite/rpl/r/rpl_backup_extra.result
> mysql-test/suite/rpl/t/rpl_backup_extra.test
> mysql-test/suite/rpl/t/rpl_backup_ptr.test
> scripts/mysql_system_tables.sql
> scripts/mysql_system_tables_fix.sql
> sql/backup/data_backup.cc
> sql/backup/image_info.cc
> sql/backup/image_info.h
> sql/backup/kernel.cc
> sql/backup/logger.h
> sql/backup/stream_v1.c
> sql/backup/stream_v1.h
> sql/log.cc
> sql/log.h
> sql/si_logs.cc
> sql/si_logs.h
