List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:May 19 2009 8:43am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (davi:2874) Bug#44672
View as plain text  
Hi, Davi!

On May 12, Davi Arnaut wrote:
>  2874 Davi Arnaut	2009-05-12
>       Bug#44672: Assertion failed: thd->transaction.xid_state.xid.is_null()
>       
> === modified file 'sql/handler.cc'
> --- a/sql/handler.cc	2009-03-27 09:34:24 +0000
> +++ b/sql/handler.cc	2009-05-12 11:55:11 +0000
> @@ -1193,6 +1193,8 @@ end:
>        or ha_rollback_trans().
>      */
>      thd->transaction.cleanup();
> +    if (is_real_trans)
> +      thd->transaction.xid_state.xid.null();

Shouldn't this be part of transaction.cleanup() ?
Logically resetting the xid is part of cleanup, isn't it ?

Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
Thread
bzr commit into mysql-5.1-bugteam branch (davi:2874) Bug#44672Davi Arnaut12 May
  • Re: bzr commit into mysql-5.1-bugteam branch (davi:2874) Bug#44672Sergei Golubchik19 May
    • Re: bzr commit into mysql-5.1-bugteam branch (davi:2874) Bug#44672Davi Arnaut19 May
      • Re: bzr commit into mysql-5.1-bugteam branch (davi:2874) Bug#44672Sergei Golubchik19 May