bzr commit into mysql-5.1-bugteam branch (kristofer.pettersson:2883) Bug#19027

[Kristofer Pettersson]

#At file:///home/thek/Development/cpp/mysqlbzr/mysql-5.1-bugteam/ based on
revid:kristofer.pettersson@stripped

 2883 Kristofer Pettersson	2009-05-18
      Bug#19027 MySQL 5.0 starts even with Fatal InnoDB errors
      
      convert_dash_to_underscore was supplied with a character length containing
      my byte too many which caused valgrind errors of invalid read.

    modified:
      sql/sql_plugin.cc
=== modified file 'sql/sql_plugin.cc'
--- a/sql/sql_plugin.cc	2009-05-14 12:03:33 +0000
+++ b/sql/sql_plugin.cc	2009-05-18 08:10:30 +0000
@@ -3314,7 +3314,7 @@ static int test_plugin_options(MEM_ROOT 
       varname= (char*) alloc_root(mem_root, len);
       strxmov(varname, tmp->name.str, "-", o->name, NullS);
       my_casedn_str(&my_charset_latin1, varname);
-      convert_dash_to_underscore(varname, len);
+      convert_dash_to_underscore(varname, len-1);
       v= new (mem_root) sys_var_pluginvar(varname, o);
     }
     DBUG_ASSERT(v); /* check that an object was actually constructed */


Attachment: [text/bzr-bundle]