Hi, Kristofer!
On May 12, Kristofer Pettersson wrote:
> 2877 Kristofer Pettersson 2009-05-12
> Bug#19027 MySQL 5.0 starts even with Fatal InnoDB errors
Thanks!
ok to push
But please remove the incorrect comment, as discussed:
> === modified file 'sql/sql_plugin.cc'
> --- a/sql/sql_plugin.cc 2009-03-16 10:37:13 +0000
> +++ b/sql/sql_plugin.cc 2009-05-12 11:38:26 +0000
> @@ -3208,64 +3265,81 @@ static int test_plugin_options(MEM_ROOT
> }
>
> - if (!*enabled && !can_disable)
> + disable_plugin= (plugin_load_policy == PLUGIN_OFF);
> + /*
> + The 'MyISAM' and 'Memory' storage engines currently can't be disabled.
> + TODO It really isn't possible to select --myisam=OFF as this option name
> + isn't registered.
> + */
This is wrong, it *is* registered. But there are many options that start
from --myisam* that's why my_getopt doesn't allow one to use it, it's
an ambiguous prefix.
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
