Hi Alfranio,
Looks good to me. FWIW, approved. Minor comments below.
On 5/12/09 10:14 PM, Alfranio Correia wrote:
> #At
> file:///home/acorreia/workspace.sun/repository.mysql/bzrwork/wl-4828/mysql-6.0-rpl/ based
> on revid:zhenxing.he@stripped
>
> 2847 Alfranio Correia 2009-05-13
> WL#4828
Always good to have some kind of explanation :)
> modified:
> dbug/dbug.c
> include/my_dbug.h
> sql/mysql_priv.h
> sql/sql_class.cc
> sql/sql_class.h
> sql/sql_partition.cc
[..]
> +
> +BOOLEAN _db_keywords_(CODE_STATE *cs, int strict, char *function, char *type)
> +{
> + char dest[_DBUG_MAX_FUNC_NAME_];
> +
> + strxnmov(dest, _DBUG_MAX_FUNC_NAME_, function, type, NULL);
> +
Due to a strxnmov idiocy the passed buffer size should be
_DBUG_MAX_FUNC_NAME_-1:
NOTE
[..]
if total-string-length >= length then dst[length] will be set to 0
Regards,
-- Davi Arnaut
