List:Commits« Previous MessageNext Message »
From:Kristofer Pettersson Date:May 11 2009 2:44pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch
(kristofer.pettersson:2877) Bug#19027
View as plain text  
Sergei Golubchik wrote:
>>
>> I'm removing the comment + the two null assignments for now.
> 
> please move them to construct_help_options and use strcmp("MyISAM" or
> "HEAP") as before.
> 
> Then bug#44691 will only need to fix hard-coded "mandatory" list, which
> is what this bug is about. And your bugfix won't break old behavior too.
> 

I would agree on not breaking old behaviour, but what _is_ the old 
behaviour? I don't see any --myisam or --memory/--heap options if I do 
"mysqld --verbose --help", do you?

We can add a hard coded test as you suggest but it wouldn't change 
anything and I still need to change it in the patch for 44691, right?




Thread
bzr commit into mysql-5.1-bugteam branch (kristofer.pettersson:2877)Bug#19027Kristofer Pettersson6 May
  • Re: bzr commit into mysql-5.1-bugteam branch(kristofer.pettersson:2877) Bug#19027Sergei Golubchik11 May
    • Re: bzr commit into mysql-5.1-bugteam branch(kristofer.pettersson:2877) Bug#19027Kristofer Pettersson11 May
      • Re: bzr commit into mysql-5.1-bugteam branch(kristofer.pettersson:2877) Bug#19027Sergei Golubchik11 May
        • Re: bzr commit into mysql-5.1-bugteam branch(kristofer.pettersson:2877) Bug#19027Kristofer Pettersson11 May
          • Re: bzr commit into mysql-5.1-bugteam branch(kristofer.pettersson:2877) Bug#19027Sergei Golubchik11 May
            • Re: bzr commit into mysql-5.1-bugteam branch(kristofer.pettersson:2877) Bug#19027Kristofer Pettersson11 May
              • Re: bzr commit into mysql-5.1-bugteam branch(kristofer.pettersson:2877) Bug#19027Sergei Golubchik11 May