Re: bzr commit into mysql-5.1-bugteam branch (kristofer.pettersson:2877) Bug#19027

[Sergei Golubchik]

Hi, Kristofer!

On May 11, Kristofer Pettersson wrote:
> Sergei Golubchik wrote:
>
>>> +    opts[0].comment= 0;
>>> +    opts[1].comment= 0;
>>> +  }
>
> I propose that we wait with fixing this issue until
> MYSQL_PLUGIN_MANDATORY is fixed. See
> http://bugs.mysql.com/bug.php?id=44691
>
> I'm removing the comment + the two null assignments for now.

please move them to construct_help_options and use strcmp("MyISAM" or
"HEAP") as before.

Then bug#44691 will only need to fix hard-coded "mandatory" list, which
is what this bug is about. And your bugfix won't break old behavior too.

Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring