Aha, I see the server code has changed since I made my patch. Fixing...new patch
soon.
Jørgen Løland wrote:
> Chuck,
>
> I'm sorry for the late review.
>
> STATUS:
> -------
> Not approved
>
> REQUEST:
> --------
> 1) Fix compile error
> 2) Fix ulonglong assignment
>
> DETAILS:
> --------
> 1)
> I get lots of compilation errors for calls to check_access similar to this:
>
> sql_parse.cc:7234: error: cannot convert ‘ulonglong*’ to
> ‘ulong*’ for
> argument ‘4’ to ‘bool check_access(THD*, ulong, const char*,
> ulong*,
> bool, bool, bool)’
>
>
> 2)
> > @@ -1325,10 +1325,10 @@ static void acl_insert_db(const char *us
> > acl_cache is not used if db_is_pattern is set.
> > */
> >
> > -ulong acl_get(const char *host, const char *ip,
> > - const char *user, const char *db, my_bool db_is_pattern)
> > +ulonglong acl_get(const char *host, const char *ip,
> > + const char *user, const char *db, my_bool
> db_is_pattern)
> > {
> > - ulong host_access= ~(ulong)0, db_access= 0;
> > + ulonglong host_access= ~(ulong)0, db_access= 0;
>
> Shouldn't this be "~(ulonglong)"?
>
>
