From: Date: June 7 2006 6:32pm
Subject: bk commit into 5.0 tree (stewart:1.2096) BUG#19318
List-Archive: http://lists.mysql.com/commits/7364
X-Bug: 19318
Message-Id: <20060607163205.1C794142887D@localhost.localdomain>

Below is the list of changes that have just been committed into a local
5.0 repository of stewart. When stewart does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2096 06/06/08 02:31:58 stewart@stripped +1 -0
  BUG#19318 valgrind: memory leak in ndb_mgmd
  
  fix based on review

  ndb/src/mgmsrv/ConfigInfo.cpp
    1.74 06/06/08 02:31:53 stewart@stripped +1 -1
    move delete to more appropriate places inside loop.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	stewart
# Host:	willster.(none)
# Root:	/home/stewart/Documents/MySQL/5.0/bug19318

--- 1.73/ndb/src/mgmsrv/ConfigInfo.cpp	2006-04-25 09:38:18 +10:00
+++ 1.74/ndb/src/mgmsrv/ConfigInfo.cpp	2006-06-08 02:31:53 +10:00
@@ -2287,6 +2287,7 @@
 
     // Replace section with modified section
     m_info.put(param._section, section, true);
+    delete section;
     
     if(param._type != ConfigInfo::CI_SECTION){
       Properties * p;
@@ -2344,7 +2345,6 @@
       ndbout << "Edit file " << __FILE__ << "." << endl;
       require(false);
     }
-    delete section;
   }
 }