List:Commits« Previous MessageNext Message »
From:Jim Winstead Date:May 7 2009 6:18pm
Subject:bzr commit into mysql-5.0-bugteam branch (jimw:2737) Bug#44424
View as plain text  
#At file:///Users/jimw/my/mysql-5.0/ based on revid:jimw@stripped

 2737 Jim Winstead	2009-05-07
      The get_date() function in mysys interpreted the GETDATE_GMT option
      backwards, which resulted in the incorrect time being reported at the
      end of mysqldump. (Bug #44424, patch by Andrew Hutchings)
      modified:
        mysys/mf_getdate.c

=== modified file 'mysys/mf_getdate.c'
--- a/mysys/mf_getdate.c	2006-12-23 19:17:15 +0000
+++ b/mysys/mf_getdate.c	2009-05-07 18:17:07 +0000
@@ -45,15 +45,15 @@ void get_date(register my_string to, int
    skr=date ? (time_t) date : time((time_t*) 0);
 #if defined(HAVE_LOCALTIME_R) && defined(_REENTRANT)
    if (flag & GETDATE_GMT)
-     localtime_r(&skr,&tm_tmp);
-   else
      gmtime_r(&skr,&tm_tmp);
+   else
+     localtime_r(&skr,&tm_tmp);
    start_time= &tm_tmp;
 #else
    if (flag & GETDATE_GMT)
-     start_time= localtime(&skr);
-   else
      start_time= gmtime(&skr);
+   else
+     start_time= localtime(&skr);
 #endif
    if (flag & GETDATE_SHORT_DATE)
      sprintf(to,"%02d%02d%02d",

Thread
bzr commit into mysql-5.0-bugteam branch (jimw:2737) Bug#44424Jim Winstead7 May