bzr commit into mysql-5.1-telco-7.0 branch (ole.john.aske:2880) Bug#44570

[Ole John Aske]

#At file:///home/oa136780/mysql/mysql-5.1-telco-7.0/ based on revid:ole.john.aske@stripped

 2880 Ole John Aske	2009-04-30
      bug#44570, In DEBUG, Disable (un)likely branch hints as they hide precious compiler warning
     @ storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp
        Remove warning created by redefined unlikely() macro

    modified:
      include/my_global.h
      storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp
=== modified file 'include/my_global.h'
--- a/include/my_global.h	2009-04-30 08:45:04 +0000
+++ b/include/my_global.h	2009-04-30 13:05:15 +0000
@@ -164,8 +164,8 @@
   No branch hinting in DEBUG as this enables warning in case
   of malformed predicates: ie. use of '=' instead if '=='
 */
-#define likely(x)	(x)
-#define unlikely(x)	(x)
+#define likely(x)	x
+#define unlikely(x)	x
 #endif
 
 /*

=== modified file 'storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp'
--- a/storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp	2008-12-09 17:02:23 +0000
+++ b/storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp	2009-04-30 13:05:15 +0000
@@ -1534,12 +1534,12 @@ int Dbtup::handleInsertReq(Signal* signa
     }
 
     if (regTabPtr->need_shrink() && cmp[0] != cmp[1] &&
-	unlikely(ret = handle_size_change_after_update(req_struct,
+	unlikely((ret = handle_size_change_after_update(req_struct,
 						       base,
 						       regOperPtr.p,
 						       regFragPtr,
 						       regTabPtr,
-						       sizes)))
+						       sizes)) < 0))
     {
       goto size_change_error;
     }


Attachment: [text/bzr-bundle] bzr/[e-mail]