List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:April 15 2009 2:54pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (mhansson:2846)
Bug#43580
View as plain text  
Hi, Martin!

On Apr 15, Martin Hansson wrote:
>  2846 Martin Hansson	2009-04-15
>       Bug#43580: Issue with Innodb on multi-table update

This looks good, but still - please add

  DBUG_ASSERT(table->read_set != &table->tmp_set);

everywhere where table->read_set= &table->tmp_set happens.
If possible in a separate changeset, as it's not part of a "fix for a
bug", technically.

Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring
Thread
bzr commit into mysql-5.1-bugteam branch (mhansson:2846) Bug#43580Martin Hansson15 Apr
Re: bzr commit into mysql-5.1-bugteam branch (mhansson:2846)Bug#43580Sergei Golubchik15 Apr