Hi, Marc!
On Mar 19, Marc Alff wrote:
>
> Replying in English for the other readers
>
> The problem:
>
> In include/mysql/psi.h today, the proposed change is to use macros like
>
> #ifdef HAVE_PERFORMANCE_SCHEMA
> #define MYSQL_FILE_PREAD <one way>
> #else
> #define MYSQL_FILE_PREAD <another way>
> #endif
>
> (Let's call this solution [1])
>
> and change the code from
>
> my_pread(...)
>
> to
>
> MYSQL_FILE_PREAD(...)
One comment about the style.
I'd prefer the instrumentation to mostly as transparent as possible to
the most of the code. And using UPPERCASE for commonly used functions
(or macros pretending to be functions) is very annoying.
Could this be mysql_file_pread() ? Pretty please ?
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring
