Hi Hema,
Ingo Strüwing, 07.04.2009 17:01:
...
> Hema Sridharan, 06.04.2009 22:15:
...
>> +# Suppress warning about expected backup/restore errors
>> +--disable_query_log
>> +call mtr.add_suppression("Backup:");
>> +call mtr.add_suppression("Restore:");
>> +--enable_query_log
>> +
>>
>> [4] Can you please suppress the warning message only related to the
>> test. This will avoid suppressing messages for entire backup and restore
>> operations.
>
> I cannot. I simply don't know how to do that. Is there a user manual for
> MTR, which explains, how add_suppression is to be used? I copied these
> lines from another test, hoping they would do the trick.
I am still awaiting an answer on this question.
>
>> The test failure result is as follows,
...
>> [1] The synchronization point gets timed out. Please make necessary
>> corrections so that test passes
After some thinking, I cannot accept this as a review. IMHO a reviewer
needs to understand the patch in every detail. If (s)he sees a problem,
(s)he tells the developer, why his patch does not work. Just applying
the patch and complaining "Your patch doesn't work, here is the log,
please fix!" is not an acceptable review.
In spite of this, I tried to repeat the failure, but failed.
On Linux and Windows, I
- branched a fresh tree from mysql-6.0-backup,
- applied the patch,
- built, and
- tested the backup_backupdir* test cases.
For Windows, I had to apply some Windows specific fixes (I'm sorry that
I didn't test on Windows before), but otherwise all tests passed. So
there is no general, obvious bug in the patch. Please investigate and
tell me what's wrong with my patch.
Regards
Ingo
--
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer
Vorsitzender des Aufsichtsrates: Martin Häring HRB München 161028
