Hi Chuck,
Chuck Bell, 30.03.2009 23:07:
> Hi Ingo,
>
> I have made an alternative patch that solves the problem for Windows.
Thank you!
...
> This has led me to the conclusion that we cannot make the code do what
> the bug report has described as a solution. That saddens me because your
> observations and suggested improvements have merit.
Well, if you only agree that we want to have the check for a directory,
then I'll come up with a solution that should also fix Bug#43767 (Wrong
path if backupdir is symlink and backref path used):
At first we let the backupdir variable value go through mf_format and
make it a clean path with symlink resolution. The result should not
contain a trailing slash any more.
Based on this conversion we can safely do the checks, and for Bug#43767,
appending the BACKUP/RESTORE image file argument will give a path
relative to the target of a symlink. So both problems should be fixed in
one go.
Can I have approval for this approach from both reviewers? I'd add it to
the bug report then.
Regards
Ingo
--
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer
Vorsitzender des Aufsichtsrates: Martin Häring HRB München 161028
