List:Commits« Previous MessageNext Message »
From:Guangbao Ni Date:March 30 2009 2:08am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (gni:2846) Bug#42640
View as plain text  
Hi, Konstantin!

According to you and sergei's discussion, I think it is the best solution
"simply downgrading ER_BINLOG_UNSAFE_STATEMENT to a "note" "

Do you agree with me? 

Thanks,
Guangbao.


Sergei Golubchik Wrote:
> Hi, Konstantin!
>
> On Mar 26, Konstantin Osipov wrote:
>   
>> * Sergei Golubchik <serg@stripped> [09/03/26 22:52]:
>>
>>     
>>> What about simply downgrading ER_BINLOG_UNSAFE_STATEMENT to a "note" ?
>>> Notes aren't promoted to errors in the strict mode, in a sense notes are
>>> "warnings which are never errors, even in a strict mode", so making
>>> ER_BINLOG_UNSAFE_STATEMENT a note is correct here.
>>>       
>> An okay solution except there won't be anything in the log if
>> sql_notes is not set ;) (a change in behaviour,
>> theoretically).
>>
>> In any case long term we will need a strategy to handle warnings
>> that should never be promoted to errors, even in strict mode.
>>     
>
> At the moment this solution is notes.
> That is, we have three levels of severity:
>
> 1. always errors
> 2. errors only in the strict mode
>    - these are called "warnings"
> 3. never errors
>    - these are called "notes"
>
> At least, this is how it was designed to work.
>  
> Regards / Mit vielen Grüßen,
> Sergei
>
>   

Thread
bzr commit into mysql-5.1-bugteam branch (gni:2846) Bug#42640Guangbao Ni12 Mar
  • Re: bzr commit into mysql-5.1-bugteam branch (gni:2846) Bug#42640Konstantin Osipov26 Mar
    • Re: bzr commit into mysql-5.1-bugteam branch (gni:2846) Bug#42640Sergei Golubchik26 Mar
      • Re: bzr commit into mysql-5.1-bugteam branch (gni:2846) Bug#42640Konstantin Osipov26 Mar
        • Re: bzr commit into mysql-5.1-bugteam branch (gni:2846) Bug#42640Sergei Golubchik26 Mar
          • Re: bzr commit into mysql-5.1-bugteam branch (gni:2846) Bug#42640Guangbao Ni30 Mar
            • Re: bzr commit into mysql-5.1-bugteam branch (gni:2846) Bug#42640Konstantin Osipov30 Mar