Hi Vlad,
Vladislav Vaintroub, 25.03.2009 02:38:
...
> a) good reviewer
> b) your work (sometimes?, also? , even?) on Windows
> c) you know what this WL is about and could you it to proceed with federated
> so I think review from you is in order:)
Thanks. <:-)
...
> Yeah, that .dll <-> .so looks hacky. But it was the simplest solution I came
> up with.
Yes, I understand.
...
> Good you noticed this. I think you also have WITH_EMBEDDED_LIBRARY set, at
> least I can reproduce it only with WITH_EMBEDDED_LIBRARY.
You are right. I used WITH_EMBEDDED_LIBRARY. It is part of my usual
build script.
> It has to do with procedure how embedded is built , it would not work with
> relative include path that are in storage/falcon/CMakeLists.txt
> I fixed it by changing relative include paths to absolute.
Ok. The build is now successful, but all tests fail:
Assertion failed: global_system_variables.table_plugin, file .\sql_plugin.cc, line 1192
I configured like this:
cscript win/configure.js __NT__ WITH_ARCHIVE_STORAGE_ENGINE WITH_BLACKHOLE_STORAGE_ENGINE
WITH_EXAMPLE_STORAGE_ENGINE WITH_FALCON_STORAGE_ENGINE WITH_FEDERATED_STORAGE_ENGINE
WITH_INNOBASE_STORAGE_ENGINE WITH_PARTITION_STORAGE_ENGINE WITH_EMBEDDED_SERVER
ENABLED_DEBUG_SYNC EXTRA_DEBUG
and did a debug build.
Leaving out all WITH_*_STORAGE_ENGINE arguments does not help.
With a release build I do just see:
mysql-test-run: *** ERROR: Error executing mysqld --bootstrap
I am using cmake version 2.6-patch 3 and VC++2005 Express Edition and
Platform SDK R2 if this helps.
BTW, I applied the patch on a current 6.0-bugteam. I had to manually
apply some changes to the root CMakeLists.txt. Does this patch require
other patches? On which tree is it based? I'm ready to try again.
...
> WITH_FEDERATED_STORAGE_ENGINE is handled the same as --with-plugin-federated
> (or --with-plugins=federated).Which means static link with mysqld, exactly
> as before the patch. I would not like to force bteam or MySQL development to
> change their existing scripts ;)
I see. Good that you have the information in the revision comment. I
would appreciate if you would also add, that WITH_*_STORAGE_ENGINE and
--with-plugin-* means static build, at other places (worklog, configure.js).
WITH_EXAMPLE_STORAGE_ENGINE seems to be an exception. Though I specified
it, it is built as DLL.
...
Regards
Ingo
--
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer
Vorsitzender des Aufsichtsrates: Martin Häring HRB München 161028
