List:Commits« Previous MessageNext Message »
From:lars-erik.bjork Date:March 16 2009 9:06am
Subject:bzr commit into mysql-6.0-falcon-team branch (lars-erik.bjork:3060) Bug#43488
View as plain text  
#At file:///home/lb200670/mysql/bugfest/ based on revid:lars-erik.bjork@stripped

 3060 lars-erik.bjork@stripped	2009-03-16
      Small changes to patch for Bug #43488 Crash in Table::fetchForUpdate (update conflict) when using LIMIT query, based on Kevin's review comments
      modified:
        storage/falcon/IndexWalker.cpp

per-file messages:
  storage/falcon/IndexWalker.cpp
    No need to release 'record'
=== modified file 'storage/falcon/IndexWalker.cpp'
--- a/storage/falcon/IndexWalker.cpp	2009-03-10 08:33:34 +0000
+++ b/storage/falcon/IndexWalker.cpp	2009-03-16 09:06:42 +0000
@@ -178,8 +178,8 @@ Record* IndexWalker::getValidatedRecord(
 	catch (SQLException& exception)
 		{
 
-		if (record && record != candidate)
-			record->release(REC_HISTORY);
+		// 'record' must be NULL if an exception has been thrown.
+		// fetchForUpdate releases the 'candidate' on error
 
 		if (candidate && !lockForUpdate)
 			candidate->release(REC_HISTORY);

Thread
bzr commit into mysql-6.0-falcon-team branch (lars-erik.bjork:3060) Bug#43488lars-erik.bjork16 Mar