| List: | Commits | « Previous MessageNext Message » | |
| From: | Kevin Lewis | Date: | March 5 2009 1:41pm |
| Subject: | Re: bzr commit into mysql-6.0-falcon-team branch (olav:3043) Bug#40155 | ||
| View as plain text | |||
Looks good to me. Olav Sandstaa wrote: > Vladislav Vaintroub wrote: >> Olav, I like the solution. Having JString using immutable const strings >> seems to be missing anyway. One minor thing : I do not find staticString >> descriptive enough (and suggests that this variable is a string rather >> than >> Boolean). Do you think isReadonly or isConst or isConstCString ,something >> like that would better describe the purpose? >> >> > > I have committed an updated patch where the name of staticString has > been renamed to isStaticString. > > The new patch also no longer use fprintf but instead use "basic" calls > to the Log that do not allocate > memory. > > The new patch is available here: > > http://lists.mysql.com/commits/68376 > > Please have a new look at it and let me know if is ok for pushing. > > Thanks, > Olav >
| Thread | ||
|---|---|---|
| • bzr commit into mysql-6.0-falcon-team branch (olav:3043) Bug#40155 | Olav Sandstaa | 2 Mar |
| • RE: bzr commit into mysql-6.0-falcon-team branch (olav:3043) Bug#40155 | Vladislav Vaintroub | 2 Mar |
| • Re: bzr commit into mysql-6.0-falcon-team branch (olav:3043) Bug#40155 | Olav Sandstaa | 2 Mar |
| • RE: bzr commit into mysql-6.0-falcon-team branch (olav:3043) Bug#40155 | Vladislav Vaintroub | 3 Mar |
| • Re: bzr commit into mysql-6.0-falcon-team branch (olav:3043) Bug#40155 | Olav Sandstaa | 3 Mar |
| • Re: bzr commit into mysql-6.0-falcon-team branch (olav:3043) Bug#40155 | Olav Sandstaa | 5 Mar |
| • Re: bzr commit into mysql-6.0-falcon-team branch (olav:3043) Bug#40155 | Kevin Lewis | 5 Mar |
