List:Commits« Previous MessageNext Message »
From:Jørgen Løland Date:March 5 2009 12:32pm
Subject:Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2783)
Bug#41979
View as plain text  
Ingo,

The patch is approved. It was easy to review since you document the code 
very well.


Ingo Struewing wrote:
> #At file:///home2/mydev/bzrroot/mysql-6.0-bug41979-1/ based on
> revid:ingo.struewing@stripped
> 
>  2783 Ingo Struewing	2009-03-04
>       Bug#41979 - Routine level grants not restored when user is dropped,
>                   recreated before restore
>       
>       BACKUP/RESTORE did not implement backup and restore of privileges
>       for stored procedures and stored functions.
>       
>       On BACKUP, we do now select routine privileges from mysql.proc_priv.
>       This is a preliminary solution until Bug 26886 / WL 2646 are implementd.
>       
>       Another BACKUP change is in the GRANT statement creation. Grants for
>       routines have the additional keyword PROCEDURE or FUNCTION after ON.
>       
>       On RESTORE, we need to be aware of the additional keyword, when we
>       search for the database name in the GRANT statement.
>      @ mysql-test/suite/backup/r/backup_db_grants.result
>         Bug#41979 - Routine level grants not restored when user is dropped,
>                     recreated before restore
>         Added test result.
>      @ mysql-test/suite/backup/r/backup_db_grants_extra.result
>         Bug#41979 - Routine level grants not restored when user is dropped,
>                     recreated before restore
>         Fixed test result.
>      @ mysql-test/suite/backup/t/backup_db_grants.test
>         Bug#41979 - Routine level grants not restored when user is dropped,
>                     recreated before restore
>         Added test.
>      @ mysql-test/suite/backup/t/backup_db_grants_extra.test
>         Bug#41979 - Routine level grants not restored when user is dropped,
>                     recreated before restore
>         Fixed test comments. RESTORE no longer fails on routine priiviliges.
>      @ sql/backup/kernel.cc
>         Bug#41979 - Routine level grants not restored when user is dropped,
>                     recreated before restore
>         Changed GRANT statement parser to find database name also in
>         routine privilege grants.
>      @ sql/si_objects.cc
>         Bug#41979 - Routine level grants not restored when user is dropped,
>                     recreated before restore
>         Fixed a compiler warning.
>         Changed GRANT statement creation to handle routine privileges.
>         Added routine privileges to privilege selection.
> 
>     modified:
>       mysql-test/suite/backup/r/backup_db_grants.result
>       mysql-test/suite/backup/r/backup_db_grants_extra.result
>       mysql-test/suite/backup/t/backup_db_grants.test
>       mysql-test/suite/backup/t/backup_db_grants_extra.test
>       sql/backup/kernel.cc
>       sql/si_objects.cc
> 


-- 
Jørgen Løland
Thread
bzr commit into mysql-6.0-backup branch (ingo.struewing:2783) Bug#41979Ingo Struewing4 Mar
  • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2783)Bug#41979Jørgen Løland5 Mar
  • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2783)Bug#41979Rafal Somla6 Mar