List:Commits« Previous MessageNext Message »
From:Vladislav Vaintroub Date:March 2 2009 6:31pm
Subject:RE: bzr commit into mysql-6.0-falcon-team branch (vvaintroub:3043)
Bug#42344 Bug#42903
View as plain text  

> -----Original Message-----
> From: Kevin.Lewis@stripped [mailto:Kevin.Lewis@stripped]
> Sent: Monday, March 02, 2009 7:20 PM
> To: Vladislav Vaintroub
> Cc: commits@stripped
> Subject: Re: bzr commit into mysql-6.0-falcon-team branch
> (vvaintroub:3043) Bug#42344 Bug#42903
> 
> Vlad,
> 
> Do not check in a comment like this;
> 
> // WTF: (whoever wrote this ^ needs to explain why exactly this order)
> 
> If you do not understand why this order is important, then get Ann to
> write it down for you, again, and add a correct comment.  Do not add
> rude or inflammatory comments.
> 
> Patch seems OK other than that.
> 

This was a comment I made for myself while reading the code. Thanks for
spotting it. 

Thread
bzr commit into mysql-6.0-falcon-team branch (vvaintroub:3043)Bug#42344 Bug#42903Vladislav Vaintroub2 Mar
  • Re: bzr commit into mysql-6.0-falcon-team branch (vvaintroub:3043)Bug#42344 Bug#42903Kevin Lewis2 Mar
    • RE: bzr commit into mysql-6.0-falcon-team branch (vvaintroub:3043)Bug#42344 Bug#42903Vladislav Vaintroub2 Mar