List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:February 26 2009 10:03pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (Alexey.Kopytov:2812)
Bug#40552
View as plain text  
* Sergei Golubchik <serg@stripped> [09/02/25 19:59]:

> >  2812 Alexey Kopytov	2009-02-25
> >       Fix for bug #40552: Race condition around default_directories  
> >                           in load_defaults() 
> >        
> >       load_defaults(), my_search_option_files() and 
> >       my_print_default_files()  utilized a global variable 
> >       containing  a pointer to thread local memory. This could lead 
> >       to race conditions when those functions were called with high 
> >       concurrency. 
> >        
> >       Fixed by changing the interface of the said functions to avoid 
> >       the necessity for using a global variable.
> 
> Not a good idea. load_defaults() is de facto part of the API, we should
> try to avoid chaning the prototype.
> 
> See how many files were affected by your small change in default.c

Hello, 

Our lovely load_defaults() again.

It's de-facto not part of the API since I never pushed the fix for
Bug#25535 "load_defaults() no longer included by mysql.h"

-- 
Thread
bzr commit into mysql-5.1-bugteam branch (Alexey.Kopytov:2812)Bug#40552Alexey Kopytov25 Feb
  • Re: bzr commit into mysql-5.1-bugteam branch (Alexey.Kopytov:2812)Bug#40552Sergei Golubchik25 Feb
    • Re: bzr commit into mysql-5.1-bugteam branch (Alexey.Kopytov:2812)Bug#40552Alexey Kopytov26 Feb
      • Re: bzr commit into mysql-5.1-bugteam branch (Alexey.Kopytov:2812)Bug#40552Sergei Golubchik26 Feb
        • Re: bzr commit into mysql-5.1-bugteam branch (Alexey.Kopytov:2812)Bug#40552Paul DuBois26 Feb
    • Re: bzr commit into mysql-5.1-bugteam branch (Alexey.Kopytov:2812)Bug#40552Konstantin Osipov26 Feb