List:Commits« Previous MessageNext Message »
From:Kevin Lewis Date:February 23 2009 2:39pm
Subject:Re: bzr commit into mysql-6.0-falcon-team branch
(lars-erik.bjork:3033) Bug#42208
View as plain text  
Lars-Erik,

Can you explain why the last two sections of code below are deleted?


>  void Index::makeKey(int count, Value **values, IndexKey *indexKey, bool highKey)
> @@ -421,17 +438,6 @@ void Index::makeKey(int count, Value **v
>  			}
>  		}
>  
> -	if (n && n < numberFields)
> -		{
> -		// We're constructing partial search key, with only some
> -		// first fields given. Append segment byte for the next
> -		// segment. This will make key larger and will hopefully
> -		// reduce the number of false positives in search (saves
> -		// work in postprocessing).
> -		if (p < (uint)database->getMaxKeyLength())
> -			key[p++] = SEGMENT_BYTE(n, numberFields);
> -		}
> -
>  	indexKey->keyLength = p;
>  }



> === modified file 'storage/falcon/StorageDatabase.cpp'
> --- a/storage/falcon/StorageDatabase.cpp	2009-02-20 12:14:41 +0000
> +++ b/storage/falcon/StorageDatabase.cpp	2009-02-23 11:49:41 +0000
> @@ -819,10 +819,7 @@ int StorageDatabase::makeKey(StorageInde
>  			int len = getSegmentValue(segment, p, values[segmentNumber],
> index->fields[segmentNumber]);
>  			
>  			if (nullFlag)
> -				{
>  				values[segmentNumber]->setNull();
> -				break;
> -				}
>  
>  			p += len;
>  			}
> 
> 
Thread
bzr commit into mysql-6.0-falcon-team branch (lars-erik.bjork:3033) Bug#42208lars-erik.bjork23 Feb
  • Re: bzr commit into mysql-6.0-falcon-team branch(lars-erik.bjork:3033) Bug#42208Kevin Lewis23 Feb