List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:February 20 2009 11:15pm
Subject:Re: bzr commit into mysql-5.0-bugteam branch (ramil:2730) Bug#35383
View as plain text  
* Ramil Kalimullin <ramil@stripped> [09/01/28 21:23]:

>  2730 Ramil Kalimullin	2009-01-28
>       Fix for bug#35383: binlog playback and replication breaks 
>       due to name_const substitution
>       
>       Problem: 
>       "In general, statements executed within a stored procedure
>       are written to the binary log using the same rules that 
>       would apply were the statements to be executed in standalone
>       fashion. Some special care is taken when logging procedure 
>       statements because statement execution within procedures 
>       is not quite the same as in non-procedure context".
>       
>       Fix: in 5.x we'll issue a warning (error???) in such a case.
>       In 6.0 we should get rid of NAME_CONST().


Right. And since your patch doesn't really provide a fix, please
leave the bug in "Verified" once you push the warning into 5.0
and 5.1. 

In 6.0 we can take metadata locks on stored procedures, and thus
we can remove unrolling completely. I will increase the risk and
effort accordingly, and ask for re-triage.

Dima, do you agree?

-- 
Thread
bzr commit into mysql-5.0-bugteam branch (ramil:2730) Bug#35383Ramil Kalimullin28 Jan
  • Re: bzr commit into mysql-5.0-bugteam branch (ramil:2730) Bug#35383Sergey Petrunia10 Feb
  • Re: bzr commit into mysql-5.0-bugteam branch (ramil:2730) Bug#35383Konstantin Osipov21 Feb