List:Commits« Previous MessageNext Message »
From:Ramil Kalimullin Date:February 14 2009 10:40am
Subject:bzr commit into mysql-5.1-bugteam branch (ramil:2799) Bug#21476
View as plain text  
#At file:///home/ram/mysql/mysql-5.1-bugteam/ based on revid:alexey.kopytov@stripped

 2799 Ramil Kalimullin	2009-02-14
      Fix for bug#21476: stack overflow crashes server; error-message
      stack reservation too small
      
      Problem: some tests fail on HP-UX due to insufficient stack reservation.
      
      Fix: increase stack reservation.
      modified:
        sql/mysql_priv.h

per-file messages:
  sql/mysql_priv.h
    Fix for bug#21476: stack overflow crashes server; error-message
    stack reservation too small
      - raised STACK_MIN_SIZE to pass execution_constants.test on HP-UX.
=== modified file 'sql/mysql_priv.h'
--- a/sql/mysql_priv.h	2009-02-09 15:03:52 +0000
+++ b/sql/mysql_priv.h	2009-02-14 10:40:22 +0000
@@ -282,16 +282,12 @@ protected:
 */
 #define TABLE_DEF_CACHE_MIN     256
 
-/* 
- Value of 9236 discovered through binary search 2006-09-26 on Ubuntu Dapper
- Drake, libc6 2.3.6-0ubuntu2, Linux kernel 2.6.15-27-686, on x86.  (Added 
- 100 bytes as reasonable buffer against growth and other environments'
- requirements.)
-
- Feel free to raise this by the smallest amount you can to get the
- "execution_constants" test to pass.
- */
-#define STACK_MIN_SIZE          12000   ///< Abort if less stack during eval.
+/*
+  Stack reservation.
+  Feel free to raise this by the smallest amount you can to get the
+  "execution_constants" test to pass.
+*/
+#define STACK_MIN_SIZE          16000   // Abort if less stack during eval.
 
 #define STACK_MIN_SIZE_FOR_OPEN 1024*80
 #define STACK_BUFF_ALLOC        352     ///< For stack overrun checks

Thread
bzr commit into mysql-5.1-bugteam branch (ramil:2799) Bug#21476Ramil Kalimullin14 Feb