List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:February 14 2009 8:09am
Subject:Re: bzr commit into mysql-5.1-bugteam branch
(alfranio.correia:2768) Bug#38174
View as plain text  
Hi, He!

On Feb 14, He Zhenxing wrote:
> Alfranio Correia wrote:
> >  2768 Alfranio Correia	2009-02-13
> >       BUG#38174 secure-file-priv breaks LOAD DATA INFILE replication in
> statement mode
> >             
> > +          DBUG_ASSERT(FALSE); 
> > +          my_error(ER_OPTION_PREVENTS_STATEMENT, MYF(0),
> "--slave-load-tmpdir");
> > +          DBUG_RETURN(TRUE);
> 
> this would cause different behavior for debug builds and normal builds,
> for debug builds, if the check fails, it will abort the server, but for
> normal builds, it just report an error and continues. I think it can
> only do this check in debug builds, if we really need to check this in
> normal builds, then please also abort the server and report it
> encountered a bug.

I think the current version is perfectly ok, but don't indend to argue
about a bikeshed color...
 
Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring
Thread
bzr commit into mysql-5.1-bugteam branch (alfranio.correia:2768)Bug#38174Alfranio Correia13 Feb
  • Re: bzr commit into mysql-5.1-bugteam branch (alfranio.correia:2768)Bug#38174He Zhenxing14 Feb
    • Re: bzr commit into mysql-5.1-bugteam branch(alfranio.correia:2768) Bug#38174Sergei Golubchik14 Feb
      • Re: bzr commit into mysql-5.1-bugteam branch (alfranio.correia:2768)Bug#38174He Zhenxing16 Feb