List:Commits« Previous MessageNext Message »
From:bar Date:May 19 2006 2:27pm
Subject:bk commit into 4.1 tree (bar:1.2486) BUG#15276
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of bar. When bar does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2486 06/05/19 17:27:31 bar@stripped +4 -0
  Bug#15276: MySQL ignores collation-server
  Problem:
  mysqld --default-collation=xxx --default-character-set=yyy
  didn't work as expected: collation_server was set not to xxx,
  but to the default collation of character set "yyy".
  
  With different argument order it worked as expected:
  mysqld --default-character-set=yyy --default-collation=yyy 
  
  Fix:
  removing wrong initialization of default_collation_name variable
  when processing --default-character-set.

  sql/mysqld.cc
    1.612 06/05/19 17:27:26 bar@stripped +0 -3
    Don't clear default_collation_name when processing 
    --default-character-set.

  mysql-test/t/ctype_ucs2_def.test
    1.2 06/05/19 17:27:26 bar@stripped +5 -0
    Adding test case.

  mysql-test/t/ctype_ucs2_def-master.opt
    1.2 06/05/19 17:27:26 bar@stripped +1 -1
    Specifying variables in reverse order, to cover the bug.

  mysql-test/r/ctype_ucs2_def.result
    1.2 06/05/19 17:27:25 bar@stripped +3 -0
    Adding test case.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	bar
# Host:	bar.intranet.mysql.r18.ru
# Root:	/usr/home/bar/mysql-4.1.b15276

--- 1.611/sql/mysqld.cc	2006-04-13 15:06:37 +05:00
+++ 1.612/sql/mysqld.cc	2006-05-19 17:27:26 +05:00
@@ -6066,9 +6066,6 @@ get_one_option(int optid, const struct m
   case 'b':
     strmake(mysql_home,argument,sizeof(mysql_home)-1);
     break;
-  case 'C':
-    default_collation_name= 0;
-    break;
   case 'l':
     opt_log=1;
     break;

--- 1.1/mysql-test/r/ctype_ucs2_def.result	2006-03-20 14:36:28 +04:00
+++ 1.2/mysql-test/r/ctype_ucs2_def.result	2006-05-19 17:27:25 +05:00
@@ -1,3 +1,6 @@
+show variables like 'collation_server';
+Variable_name	Value
+collation_server	ucs2_unicode_ci
 show variables like "%character_set_ser%";
 Variable_name	Value
 character_set_server	ucs2

--- 1.1/mysql-test/t/ctype_ucs2_def-master.opt	2006-03-20 14:36:28 +04:00
+++ 1.2/mysql-test/t/ctype_ucs2_def-master.opt	2006-05-19 17:27:26 +05:00
@@ -1 +1 @@
---default-character-set=ucs2 --default-collation=ucs2_unicode_ci
+--default-collation=ucs2_unicode_ci --default-character-set=ucs2

--- 1.1/mysql-test/t/ctype_ucs2_def.test	2006-03-20 14:36:28 +04:00
+++ 1.2/mysql-test/t/ctype_ucs2_def.test	2006-05-19 17:27:26 +05:00
@@ -1,4 +1,9 @@
 #
+# MySQL Bug#15276: MySQL ignores collation-server
+#
+show variables like 'collation_server';
+
+#
 # Bug#18004 Connecting crashes server when default charset is UCS2
 #
 show variables like "%character_set_ser%";
Thread
bk commit into 4.1 tree (bar:1.2486) BUG#15276bar19 May