STATUS
------
Patch approved pending one request.
REQUESTS
--------
1. I still think we need to keep the data type to ulong because on some
platforms one can have more than uint number of objects.
DETAILS
-------
> 2770 Jorgen Loland 2009-02-12
> Bug#39109 - Mysql Online Backup table doesn't show correct num_object count
>
> Previously, the num_objects column in the backup_history table showed the
> number of
> tables in the backup image. It now shows the number of objects with names
> (i.e,
> tablespace, database, table, view, routine)
> added:
> mysql-test/suite/backup/r/backup_object_count.result
> mysql-test/suite/backup/t/backup_object_count.test
> modified:
> mysql-test/suite/backup/r/backup_logs.result
> mysql-test/suite/backup/t/backup_logs.test
> sql/backup/image_info.cc
> sql/backup/image_info.h
> sql/backup/logger.cc
...
> /// Returns total number of tables in the image.
> inline
> -ulong Image_info::table_count() const
> +uint Image_info::table_count() const
> {
> return m_table_count;
> }
[1] I think this and the other count functions should return ulong to be
safe. The number of objects counted could exceed uint.
Chuck
