Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741) Bug#32702 WL#4644

[Jørgen Løland]

STATUS:
-------
Patch approved

REQUESTS:
---------

SUGGESTIONS:
------------
1. There are a few instances of the text DDL left in the bml.cc file. I 
suggest you search and replace these
2. Document bml code in sql_parse.cc

COMMENTS:
---------
Very nice job. The test is really good.

DETAILS:
--------
1)
 > +   @returns TRUE if not blocked
 > +   @returns FALSE if ddl is blocked and timeout occurs
 > +*/
 > +my_bool BML_class::bml_enter(THD *thd)

Example remaining "ddl" text.

2)
 > @@ -1822,6 +1870,7 @@ mysql_execute_command(THD *thd)
 >  #ifdef WITH_PARTITION_STORAGE_ENGINE
 >    thd->work_part_info= 0;
 >  #endif
 > +  bool bml_registered= FALSE;

Add a comment for bml_registered

 > @@ -1994,6 +2043,15 @@ mysql_execute_command(THD *thd)
 >    if (opt_implicit_commit(thd, CF_IMPLICT_COMMIT_BEGIN))
 >      goto error;
 >
 > +  if (is_bml_blocked(lex->sql_command) &&
 > +      !(bml_registered= BML_instance->bml_enter(thd)))
 > +    goto error;

Add a comment explaining this if-block



Rafal Somla wrote:
> Hi Chuck,
> 
> I have updated my patch to the latest 6.0-backup tree 
> (revid:jorgen.loland@stripped).
> 
> I have addressed the issues you raised. As discussed in Stockholm I 
> created a branch with my patch - you can pull changes from there and 
> then all renames should be correctly handled by bzr. The url of the 
> branch is:
> 
> bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-6.0-backup-bug32702



-- 
Jørgen Løland