| List: | Commits | « Previous MessageNext Message » | |
| From: | Rafal Somla | Date: | February 13 2009 7:46am |
| Subject: | Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741) Bug#32702 WL#4644 | ||
| View as plain text | |||
Chuck, thanks for a quick review and your earlier efforts which helped to make this patch more complete. Jorgen, please reserve some time for reviewing this monster patch. Rafal Chuck Bell wrote: > STATUS > ------ > Patch approved. > > REQUESTS > -------- > None > > COMMENTARY > ---------- > Thanks for the extra effort to make reviewing this large patch easier. > I accept your explanation for not moving functions to si_objects. > I noted the patch acceptance state in the worklog and bug report. > > DETAILS > ------- >> I have updated my patch to the latest 6.0-backup tree >> (revid:jorgen.loland@stripped). >> >> I have addressed the issues you raised. As discussed in Stockholm I >> created a branch with my patch - you can pull changes from there and >> then all renames should be correctly handled by bzr. The url of the >> branch is: >> >> bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-6.0-backup-bug32702 >> >> I'm waiting for your review of the updated patch. >>
