List:Commits« Previous MessageNext Message »
From:V Narayanan Date:February 11 2009 5:09pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (v.narayanan:2750)
Bug#40675
View as plain text  
Thank you for the comments and the approval to push  Kostja!

Narayanan

Konstantin Osipov wrote:
> * V Narayanan <V.Narayanan@stripped> [09/02/11 15:48]:
>   
>> +    /*
>> +    Open and attaches the MyISAM tables,that are under the MERGE table 
>> +    parent, on the MyISAM storage engine interface directly within the
>> +    MERGE engine. The new MyISAM table instances, as well as the MERGE 
>> +    clone itself, are not visible in the table cache. This is not a 
>> +    problem because all locking is handled by the original MERGE table
>> +    from which this is cloned of.
>> +    */
>>     
>
> Please align the comment to follow the coding style:
>
>   
>> +    /*
>> +      Open and attaches the MyISAM tables,that are under the MERGE table 
>> +      parent, on the MyISAM storage engine interface directly within the
>> +      MERGE engine. The new MyISAM table instances, as well as the MERGE 
>> +      clone itself, are not visible in the table cache. This is not a 
>> +      problem because all locking is handled by the original MERGE table
>> +      from which this is cloned of.
>> +    */
>>     
>
> <cut>
>
>   
>> +/**
>> + * Returns a cloned instance of the current handler.
>> + *
>> + * @return A cloned handler instance.
>> + */
>>     
>
> Correct alignment is:
>
>   
>> +/**
>> +  Returns a cloned instance of the current handler.
>> +  
>> +  @return A cloned handler instance.
>> +*/
>>     
>
> OK to push.
>
>   

Thread
bzr commit into mysql-5.1-bugteam branch (v.narayanan:2750) Bug#40675V Narayanan11 Feb
  • Re: bzr commit into mysql-5.1-bugteam branch (v.narayanan:2750)Bug#40675Konstantin Osipov11 Feb
    • Re: bzr commit into mysql-5.1-bugteam branch (v.narayanan:2750)Bug#40675V Narayanan11 Feb