List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:February 9 2009 1:28pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (chad:2725) Bug#30261
View as plain text  
On 1/20/09 2:13 PM, Chad MILLER wrote:
> #At file:///home/cmiller/work/mysqlbzr/mysql-5.1-bugteam--bug30261/ based on
> revid:kgeorge@stripped
>
>   2725 Chad MILLER	2009-01-20
>        Bug#30261: "mysqld --help" no longer possible for root
>
>        The check for root-ness would signal an error.  Errors would make the
>        server exit before usage (help) information was printed.
>
>        Now, test for whether we want help regardless of whether we're going
>        to exit with an error.
> modified:
>    sql/mysqld.cc
>
> === modified file 'sql/mysqld.cc'
> --- a/sql/mysqld.cc	2008-11-28 15:27:12 +0000
> +++ b/sql/mysqld.cc	2009-01-20 16:09:14 +0000
> @@ -1176,10 +1176,10 @@ extern "C" void unireg_abort(int exit_co
>   {
>     DBUG_ENTER("unireg_abort");
>
> +  if (opt_help) {
> +    usage();

I agree with Serg's request and also please fix the coding style violation.

Regards,

-- Davi

Thread
bzr commit into mysql-5.1-bugteam branch (chad:2725) Bug#30261Chad MILLER20 Jan
  • Re: bzr commit into mysql-5.1-bugteam branch (chad:2725) Bug#30261Sergei Golubchik5 Feb
  • Re: bzr commit into mysql-5.1-bugteam branch (chad:2725) Bug#30261Davi Arnaut9 Feb