Hi, Gleb!
On Feb 09, Gleb Shchepa wrote:
> Hello Sergei and Konstantin!
>
> Thank you for a review.
> Will add an additional mutex.
Rememeber, it's a suboptimal solution, I suggest you to think about
this problem a bit and try to come up with something better.
>Sergei Golubchik wrote:
>> On Feb 08, Konstantin Osipov wrote:
>>> * Gleb Shchepa <gshchepa@stripped> [08/11/12 13:51]:
>>>> 2714 Gleb Shchepa 2008-11-12
>>>> Bug #38816: kill + flush tables with read lock + stored
>>>> procedures causes crashes!
>>>>
>>>> The problem of that bugreport was mostly fixed by the patch
>>>> for bug 38691. However, attached test case focused on
>>>> another crash or valgrind warning problem: SHOW PROCESSLIST
>>>> query accesses freed memory of SP instruction that run in a
>>>> parallel connection.
>>
>> There are better solutions. The first that comes to my mind - use a
>> dedicated per-thread mutex to protect thd->query and
>> thd->query_length. It's not the best solution, but a simplest one,
>> for sure.
>>
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring