List:Commits« Previous MessageNext Message »
From:Rafal Somla Date:February 6 2009 10:23am
Subject:Re: Bug still exists Re: bzr commit into mysql-6.0-backup branch
(ingo.struewing:2737) Bug#40944
View as plain text  
Ingo Strüwing wrote:
> 
> It may be good to have their opinion to my view:
> 
> The RESTORE locking scheme has been developed before Dmitri's Meta Data
> Locks (MDL) existed. There seems to be common agreement that we should
> refactor it so that it takes exclusive MDL for all tables to be
> restored. Before even creating the tables, I think. Once this is done,
> the SELECT would be blocked even before attempting to open the table. So
> it wouldn't mark it "in_use". The lock would persist until RESTORE
> finishes. That is, until after close_cached_tables().
>

I double Ingo's opinion: we should try to take MDL locks inside RESTORE before 
creating the tables and release them only after all is done. This seems to me to 
be the most clean solution.

Rafal

Thread
bzr commit into mysql-6.0-backup branch (ingo.struewing:2737) Bug#40944Ingo Struewing3 Dec
  • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2737)Bug#40944Øystein Grøvlen18 Dec
    • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2737)Bug#40944Ingo Strüwing18 Dec
      • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2737)Bug#40944Øystein Grøvlen19 Dec
  • Bug still exists Re: bzr commit into mysql-6.0-backup branch(ingo.struewing:2737) Bug#40944Guilhem Bichot6 Feb
    • Re: Bug still exists Re: bzr commit into mysql-6.0-backup branch(ingo.struewing:2737) Bug#40944Ingo Strüwing6 Feb
      • Re: Bug still exists Re: bzr commit into mysql-6.0-backup branch(ingo.struewing:2737) Bug#40944Rafal Somla6 Feb