On 27/01 17.03, Andrei Elkin wrote:
> Bjorn, hello.
>
> > #At file:///home/bm136801/mysql/5.0-42216/
> >
> > 2732 Bjorn Munch 2009-01-27
> > Bug #42216 mysqltest: Use of diff belonging to current OS, with wrong
> option for Solaris
> > Call the check_diff() only if Windows, also fixed wrong flag
> > if diff failed
>
> Could you please provide the problem description section/clause and
> the idea of your solution?
What do you mean by "problem description section/clause", does this
have some specific meaning I should know about?
> > +#ifdef __WIN__
> > have_diff = diff_check();
> > +#else
> > + have_diff = 1;
> > +#endif
>
> I think you need to mention somewhere (e.g at top level comments) why
> diff_check() is necessary only on windows.
> How `diff' is supposed to be found on other platforms.
OK, it's like this: if you don't have diff it will in any case fail
with a message you couldn't run diff. But the assumtion is that this
is very unlikely to be missing on *nix.
The diff_check() was also added specifically for Windows due to
problems with handling failures, so it's really only on Windows it was
needed in the first place. See Bug #38833.
I will add comments.
I see Alfranio has already commented per email with something similar.
Sorry for not answering this email sooner, I need to update my filters
so I get relevant replies to the commit mailing list.
- Bjorn
