List:Commits« Previous MessageNext Message »
From:Andrei Elkin Date:January 21 2009 5:06pm
Subject:bzr commit into mysql-5.1-bugteam branch (aelkin:2749) Bug#31240
View as plain text  
#At file:///home/andrei/MySQL/BZR/FIXES/bug31240-ldi_41_2_51/ based on revid:staale.smedseng@stripped

 2749 Andrei Elkin	2009-01-21
      Bug #31240 load data infile replication between (4.0 or 4.1) and 5.1 fails
      
      The reason of the bug appeared to be an error introduced into 5.1 source code.
      That piece of code in Create_file_log_event::do_apply_event() did not have test coverage
      which allowed make test and pb pass smooth.
      
      Fixed with inverting the old value of the return value from 
      Create_file_log_event::do_apply_event().
modified:
  sql/log_event.cc

per-file messages:
  sql/log_event.cc
    Correcting the return value from  Create_file_log_event::do_apply_event()
=== modified file 'sql/log_event.cc'
--- a/sql/log_event.cc	2009-01-14 09:32:25 +0000
+++ b/sql/log_event.cc	2009-01-21 17:06:03 +0000
@@ -5945,8 +5945,15 @@ void Create_file_log_event::pack_info(Pr
 #endif /* defined(HAVE_REPLICATION) && !defined(MYSQL_CLIENT) */
 
 
-/*
+/**
   Create_file_log_event::do_apply_event()
+  Constructor for Create_file_log_event to intantiate an event
+  from the relay log on the slave.
+
+  @retval
+    0           Success
+  @retval
+    1           Failure
 */
 
 #if defined(HAVE_REPLICATION) && !defined(MYSQL_CLIENT)
@@ -6015,7 +6022,7 @@ err:
   if (fd >= 0)
     my_close(fd, MYF(0));
   thd_proc_info(thd, 0);
-  return error == 0;
+  return error != 0;
 }
 #endif /* defined(HAVE_REPLICATION) && !defined(MYSQL_CLIENT) */
 

Thread
bzr commit into mysql-5.1-bugteam branch (aelkin:2749) Bug#31240Andrei Elkin21 Jan