List:Commits« Previous MessageNext Message »
From:Leonard Zhou Date:January 13 2009 8:41am
Subject:bzr commit into mysql-5.1 branch (zhou.li:2787) Bug#34526
View as plain text  
#At file:///home/zhl/mysql/mysql-5.1-telco-6.2-bug34526/

 2787 Leonard Zhou	2009-01-13
      BUG#34526 Remove backup report when backup failed
modified:
  storage/ndb/src/kernel/blocks/backup/Backup.cpp
  storage/ndb/src/ndbapi/ndberror.c

per-file messages:
  storage/ndb/src/kernel/blocks/backup/Backup.cpp
    Remove backup report when backup failed
  storage/ndb/src/ndbapi/ndberror.c
    Add error message
=== modified file 'storage/ndb/src/kernel/blocks/backup/Backup.cpp'
--- a/storage/ndb/src/kernel/blocks/backup/Backup.cpp	2008-09-30 06:55:35 +0000
+++ b/storage/ndb/src/kernel/blocks/backup/Backup.cpp	2009-01-13 08:39:34 +0000
@@ -2320,7 +2320,7 @@ Backup::stopBackupReply(Signal* signal, 
 
   sendAbortBackupOrd(signal, ptr, AbortBackupOrd::BackupComplete);
   
-  if(!ptr.p->checkError())
+  if(!ptr.p->checkError() &&  ptr.p->masterData.errorCode == 0)
   {
     if (SEND_BACKUP_COMPLETED_FLAG(ptr.p->flags))
     {
@@ -4908,6 +4908,7 @@ Backup::execABORT_BACKUP_ORD(Signal* sig
   default:
 #endif
     ptr.p->setErrorCode(requestType);
+    ptr.p->masterData.errorCode = requestType;
     ok= true;
   }
   ndbrequire(ok);

=== modified file 'storage/ndb/src/ndbapi/ndberror.c'
--- a/storage/ndb/src/ndbapi/ndberror.c	2008-10-21 13:00:33 +0000
+++ b/storage/ndb/src/ndbapi/ndberror.c	2009-01-13 08:39:34 +0000
@@ -686,6 +686,7 @@ ErrorBundle ErrorCodes[] = {
   { 4298, DMEC, AE, "Invalid or unsupported ScanOptions structure" },
   { 4299, DMEC, AE, "Incorrect combination of ScanOption flags, extraGetValues ptr and numExtraGetValues" },
   { 2810, DMEC, TR, "No space left on the device" },
+  { 2811, DMEC, TR, "Error with file permissions, please check file system" },
   { 2815, DMEC, TR, "Error in reading files, please check file system" },
 
   { NO_CONTACT_WITH_PROCESS, DMEC, AE,

Thread
bzr commit into mysql-5.1 branch (zhou.li:2787) Bug#34526Leonard Zhou13 Jan