bzr commit into mysql-6.0-falcon-team branch (klewis:2973) Bug#36700

[Kevin Lewis]

#At file:///C:/Work/bzr/Merge/mysql-6.0-falcon-team/

 2973 Kevin Lewis	2009-01-13
      Bug#36700 - Found while running the new scavenger with 
      falcon_bug_28048.  The variable neededByAnyActiveTrans
      in RecordVersion::retire() was set incorrectly.  
      So retireRecords did not work correctly.
modified:
  storage/falcon/RecordVersion.cpp

per-file messages:
  storage/falcon/RecordVersion.cpp
    Bug#36700 - Found while running the new scavenger with 
    falcon_bug_28048.  The variable neededByAnyActiveTrans
    in RecordVersion::retire() was set incorrectly.  
    So retireRecords did not work correctly.
=== modified file 'storage/falcon/RecordVersion.cpp'
--- a/storage/falcon/RecordVersion.cpp	2009-01-09 21:49:16 +0000
+++ b/storage/falcon/RecordVersion.cpp	2009-01-13 08:39:22 +0000
@@ -182,10 +182,10 @@ void RecordVersion::commit()
 
 bool RecordVersion::retire(RecordScavenge *recordScavenge)
 {
-	bool neededByAnyActiveTrans = false;
+	bool neededByAnyActiveTrans = true;
 	if (  !transaction 
 		|| transaction->committedBefore(recordScavenge->oldestActiveTransaction))
-		neededByAnyActiveTrans = true;
+		neededByAnyActiveTrans = false;
 
 	if (   generation <= recordScavenge->scavengeGeneration
 		&& useCount == 1