List:Commits« Previous MessageNext Message »
From:John H. Embretsen Date:January 12 2009 9:01pm
Subject:Re: bzr commit into mysql-6.0-falcon-team branch (lars-erik.bjork:2972)
View as plain text  
Hi Lars-Erik,

The new tests look good to me, OK to push, once you have approval of
code patch (current version at http://lists.mysql.com/commits/62959 ).

Is there a bug number typo in the commit comment? (see below)

I ran the tests first without the code patch (tests failed, as they
should) and then with the code patch (tests passed). Note that I had to
run 'make clean' before 'make' after applying the code patch in order to
get the tests to run OK.


Lars-Erik.Bjork@stripped wrote:
> #At file:///home/lb200670/devel/mysql/trampoline/ based on
> revid:lars-erik.bjork@stripped
> 
>  2972 lars-erik.bjork@stripped	2009-01-12
>       This commit contains tests for two bugs:
>       
>       bug#40607 Unsigned indexes broken
>       
>       bug#41582 Index access returns no result for indexes with numeric
>       data type
>       ------------------------------------------------------------------
(...)

>       Added file 'mysql-test/suite/falcon/t/falcon_bug_41582.test'
>       ------------------------------------------------------------
>       Added a test testing that the patch fixes #40607. Tests for the decimal

You mean testing that the patch fixes #41582?

(...)

> added:
>   mysql-test/suite/falcon/r/falcon_bug_40607.result
>   mysql-test/suite/falcon/r/falcon_bug_41582.result
>   mysql-test/suite/falcon/t/falcon_bug_40607.test
>   mysql-test/suite/falcon/t/falcon_bug_41582.test
(...)

-- 
John
Thread
bzr commit into mysql-6.0-falcon-team branch (lars-erik.bjork:2972) lars-erik.bjork12 Jan
  • Re: bzr commit into mysql-6.0-falcon-team branch (lars-erik.bjork:2972)John H. Embretsen12 Jan
    • Re: bzr commit into mysql-6.0-falcon-team branch (lars-erik.bjork:2972)Lars-Erik Bjørk13 Jan