Hi, Georg!
On Jan 08, Georg Richter wrote:
> Sergei Golubchik wrote:
>
> >> + if (mysql->charset->number == 45 &&
> mysql->server_version[0] < '6')
> >> + buff[8]= 33;
> >
> > Same question that I asked Georg - why you don't need to change
> > mysql->charset->number to be 33 here ?
>
> We don't change mysql->charset->number, we just tell the server that
> we're using cs number 33 - utf8 3-byte.
>
> According to Bar this is safe, but needs to be documented. Special
> characters which requires 4-byte UTF( will result in '?' when running
> against a 5.1 server.
okay, then just add a comment that this is safe and why, and
ok to push
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring
