Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741) Bug#32702 WL#4644

[Rafal Somla]

Hi Chuck,

Chuck Bell wrote:
> Rafal,
> 
>> See my explanations below. None of your concerns will result in any 
>> meaningful changes of the code I submitted (except for updating one 
>> patch comment and removing wrong tabs from the test script). So I 
>> think you can continue reviewing the patch as it is now.
> 
> I disagree. I can/may use it to approve the architecture but I cannot 
> accept it as a code review until I can successfully apply the patch, 
> compile, and execute the code.
> 
> I have received other patches from other developers with renamed files 
> (and even deleted ones) and they all worked fine. Perhaps it is how you 
> are telling bzr to do the rename.
> 

I use "bzr move <old name> <new name>" which is the correct way.

Note that the patch you are viewing is not produced by me but by bzr. I do the 
normal development - change code, move files around with "bzr move", delete them 
with "bzr rm", add new ones with "bzr add" and so on. Then I commit the changes 
creating a change set. The "bzr gcommit" program generates the diff and sends it 
around so that you can review it. I have no influence on how this diff is 
generated - I'm not bzr but mysql developer.

Actually, I do not understand your problem. Why do you insist on feeding a 
bzr-generated patch to the standard patch tool? It usually works but no one said 
it has to work at all times. If you managed to successfully apply a bzr-patch 
with renames in the past, can you send me one such patch - I'd be interested in 
examining it.

As far as I know, the standard patch utility does not handle file renames. 
Perhaps you want to use e.g., cg-patch utility which supports such functionality 
<http://www.kernel.org/pub/software/scm/cogito/docs/cg-patch.1.html>? Another 
option would be that I set-up a branch with my code on one of our servers and 
you pull the changes from there.

Either way, I hope you mange to resolve the issues with your working environment 
and let me know if you consider this patch correct and good enough to be pushed 
to our trees.

Rafal