Chuck,
The code looks good, but the test fails after applying the patch.
Requests:
-----------------
1. Fix test [1]
2. Fix typo in test [2]
Suggestions:
----------------------
1. Improve readability of result file by adding a few blank lines
Question:
----------------
1. Why do you print the backup ids? Are the values 505 and
506 confirming something that I'm failing to see? Are the values
deterministic?
Details:
-------------
[1]
@@ -60,7 +60,7 @@
Replicate_Ignore_DB
Replicate_Do_Table
Replicate_Ignore_Table
-Replicate_Wild_Do_Table rpl_backup.%
+Replicate_Wild_Do_Table
Replicate_Wild_Ignore_Table
Last_Errno 0
Last_Error
@@ -119,7 +119,7 @@
Replicate_Ignore_DB
Replicate_Do_Table
Replicate_Ignore_Table
-Replicate_Wild_Do_Table rpl_backup.%
+Replicate_Wild_Do_Table
Replicate_Wild_Ignore_Table
Last_Errno 0
Last_Error
@@ -206,7 +206,7 @@
Replicate_Ignore_DB
Replicate_Do_Table
Replicate_Ignore_Table
-Replicate_Wild_Do_Table rpl_backup.%
+Replicate_Wild_Do_Table
Replicate_Wild_Ignore_Table
Last_Errno 1590
Last_Error The incident RESTORE_ON_MASTER occured on the master.
Message: A restore operation was initiated on the master.
@@ -354,7 +354,7 @@
Replicate_Ignore_DB
Replicate_Do_Table
Replicate_Ignore_Table
-Replicate_Wild_Do_Table rpl_backup.%
+Replicate_Wild_Do_Table
Replicate_Wild_Ignore_Table
Last_Errno 0
Last_Error
@@ -407,7 +407,7 @@
Replicate_Ignore_DB
Replicate_Do_Table
Replicate_Ignore_Table
-Replicate_Wild_Do_Table rpl_backup.%
+Replicate_Wild_Do_Table
Replicate_Wild_Ignore_Table
Last_Errno 0
Last_Error
@@ -452,6 +452,7 @@
Database
information_schema
mysql
+not_replicated
rpl_backup
test
Now back to the master to make a backup of the new database.
mysqltest: Result content mismatch
[2]
/* Used to specify if RESTORE should skup writing the gap event. */
skup->skip
