List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:January 5 2009 4:17pm
Subject:Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)
Bug#32702 WL#4644
View as plain text  
Rafal,

CORRECTION

> I disagree. I can/may use it to approve the architecture but I cannot 
> accept it as a code review until I can successfully apply the patch, 
> compile, and execute the code.

I approved the architecture on 10 December 2008. I cannot approve the 
patch until I can successfully apply and compile it.

UPDATE

I applied the patch on Linux. Except for the Visual Studio issues, the 
same errors occur and the patch is not applied correctly nor can it 
compile. The renames do not work either.

I would ask that you try it yourself and when you are successful email 
me the process you used to get it to work. Again, let me remind you I 
have successfully applied patches from others that contained renames and 
deleted files using 'patch -p1 -u ...'. I am also aware that there are 
several ways to rename files. I think it is possible you are not using 
one that is patch friendly.

Chuck
Thread
bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741) Bug#32702 WL#4644Rafal Somla17 Dec
  • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Chuck Bell17 Dec
    • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Rafal Somla18 Dec
      • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Chuck Bell5 Jan
        • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Chuck Bell5 Jan
        • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Rafal Somla8 Jan
  • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Chuck Bell22 Jan
    • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Rafal Somla11 Feb
      • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Chuck Bell12 Feb
        • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Rafal Somla13 Feb
      • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2741)Bug#32702 WL#4644Jørgen Løland13 Feb