2752 Sergey Petrunia 2008-12-27
Added comments
modified:
sql/opt_range.h
2751 Sergey Petrunia 2008-12-27
BUG#41759: Valgrind warning: Invalid read of size 1 open_tables() with ps-protocol
- In open_tables(): Don't try accessing tables->table_name before is guaranteed to have a valid
value (see the code between the two locations for code and comments about when the table may not
have a valid name when passed to open_tables).
modified:
sql/sql_base.cc
=== modified file 'sql/opt_range.h'
--- a/sql/opt_range.h 2008-08-25 18:23:27 +0000
+++ b/sql/opt_range.h 2008-12-27 02:32:25 +0000
@@ -108,7 +108,11 @@ class QUICK_RANGE :public Sql_alloc {
4. Delete the select:
delete quick;
-
+
+ NOTE
+ quick select doesn't use Sql_alloc/MEM_ROOT allocation because "range
+ checked for each record" functionality may create/destroy
+ O(#records_in_some_table) quick selects during query execution.
*/
class QUICK_SELECT_I
| Thread |
|---|
| • bzr push into mysql-6.0-opt-subqueries branch (sergefp:2751 to 2752) | Sergey Petrunia | 27 Dec |
