List:Commits« Previous MessageNext Message »
From:Sergey Petrunia Date:December 25 2008 10:58am
Subject:Re: bzr push into mysql-6.0 branch (alik:2712 to 2713) Bug#41729
View as plain text  
Hi!

On Thu, Dec 25, 2008 at 10:34:55AM +0300, Alexander Nozdrin wrote:
>  2713 Alexander Nozdrin	2008-12-25
>       Fix for Bug#41729: Valgrind warnings in setup_wild().
>       
>       The problem is in the line below:
>       [sql_base.cc:setup_wild()]
>         select_lex->item_list= fields;
>       
>       This assignment is translated to memcpy() call (at least on some
>       platforms). memcpy() expects that source and destination areas do not
>       overlap.
>       
>       The fix is to do the assignment only if needed.

It doesnt solve the two other problems. I've pushed it into -opt-subqueries
tree yesterday, and now valgrind shows that the errors are still there.

BR
 Sergey
-- 
Sergey Petrunia, Lead Software Engineer
MySQL AB, www.mysql.com
Office: N/A
Blog: http://s.petrunia.net/blog
Thread
bzr push into mysql-6.0 branch (alik:2712 to 2713) Bug#41729Alexander Nozdrin25 Dec
  • Re: bzr push into mysql-6.0 branch (alik:2712 to 2713) Bug#41729Sergey Petrunia25 Dec