From: Date: December 23 2008 1:12am Subject: Re: bzr commit into mysql-5.1-bugteam branch (davi:2741) Bug#37016 List-Archive: http://lists.mysql.com/commits/62230 Message-Id: <49502CF5.6020005@Sun.COM> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT On 12/22/08 9:35 PM, Sergei Golubchik wrote: > Hi, Davi! > > On Dec 22, Davi Arnaut wrote: >> Hi Sergei, >> >> On 12/22/08 8:48 PM, Sergei Golubchik wrote: >>> Hi, Davi! >>> >>> On Dec 13, Davi Arnaut wrote: >>>> # At a local mysql-5.1-bugteam repository of davi >>>> >>>> 2741 Davi Arnaut 2008-12-13 >>>> Bug#37016: TRUNCATE TABLE removes some rows but not all >>>> >>> 3. removed the code that was enabling autocommit >>> * why ? >> Because it's not necessary as the TRUNCATE transaction is explicitly ended >> (committed or rolled back). IMHO, there is no need for a yet another >> special case here... or I'm missing something? > > Nothing that I know of :) > I was not against that change, it looked ok, > just wanted to know your reasoning. > > Ok to push > OK, thanks! I'm going to re-commit with a more explicit note about it. -- Davi