Re: bzr commit into mysql-5.1-bugteam branch (davi:2741) Bug#37016

[Sergei Golubchik]

Hi, Davi!

On Dec 22, Davi Arnaut wrote:
> Hi Sergei,
>
> On 12/22/08 8:48 PM, Sergei Golubchik wrote:
>> Hi, Davi!
>>
>> On Dec 13, Davi Arnaut wrote:
>>> # At a local mysql-5.1-bugteam repository of davi
>>>
>>>   2741 Davi Arnaut	2008-12-13
>>>        Bug#37016: TRUNCATE TABLE removes some rows but not all
>>>
>> 3. removed the code that was enabling autocommit
>>   * why ?
>
> Because it's not necessary as the TRUNCATE transaction is explicitly ended 
> (committed or rolled back). IMHO, there is no need for a yet another 
> special case here... or I'm missing something?

Nothing that I know of :)
I was not against that change, it looked ok,
just wanted to know your reasoning.

Ok to push

Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring