List:Commits« Previous MessageNext Message »
From:msvensson Date:January 4 2006 4:02pm
Subject:bk commit into 5.0 tree (msvensson:1.2009) BUG#15598
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2009 06/01/04 17:02:11 msvensson@neptunus.(none) +3 -0
  Bug #15598 Server crashes in specific case during setting new password
  - Comparing host string against NULL caused crash. 
  - If host.hostname is NULL treat it as ""

  sql/sql_acl.cc
    1.185 06/01/04 17:02:02 msvensson@neptunus.(none) +3 -2
    If host.host_name is NULL in acl_user it should be evaluated as ""

  mysql-test/t/grant.test
    1.37 06/01/04 17:02:02 msvensson@neptunus.(none) +11 -0
    Add test for user with host ""

  mysql-test/r/grant.result
    1.47 06/01/04 17:02:02 msvensson@neptunus.(none) +8 -0
    Update test results

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	neptunus.(none)
# Root:	/home/msvensson/mysql/bug15598/my50-bug15598

--- 1.184/sql/sql_acl.cc	2005-12-06 17:04:21 +01:00
+++ 1.185/sql/sql_acl.cc	2006-01-04 17:02:02 +01:00
@@ -1528,7 +1528,8 @@
 	acl_user->user && !strcmp(user,acl_user->user))
     {
       if (exact ? !my_strcasecmp(&my_charset_latin1, host,
-                                 acl_user->host.hostname) :
+                                 acl_user->host.hostname ?
+				 acl_user->host.hostname : "") :
           compare_hostname(&acl_user->host,host,host))
       {
 	DBUG_RETURN(acl_user);
@@ -4913,7 +4914,7 @@
       acl_user= dynamic_element(&acl_users, idx, ACL_USER*);
       user= acl_user->user;
       if (!(host= acl_user->host.hostname))
-        host= "%";
+        host= "";
       break;
 
     case 1:

--- 1.46/mysql-test/r/grant.result	2005-11-28 14:06:26 +01:00
+++ 1.47/mysql-test/r/grant.result	2006-01-04 17:02:02 +01:00
@@ -615,3 +615,11 @@
 Grants for root@localhost
 GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' WITH GRANT OPTION
 set names latin1;
+create user mysqltest_7@;
+set password for mysqltest_7@ = password('systpass');
+show grants for mysqltest_7@;
+Grants for mysqltest_7@
+GRANT USAGE ON *.* TO 'mysqltest_7'@'' IDENTIFIED BY PASSWORD '*2FB071A056F9BB745219D9C876814231DAF46517'
+drop user mysqltest_7@;
+show grants for mysqltest_7@;
+ERROR 42000: There is no such grant defined for user 'mysqltest_7' on host ''

--- 1.36/mysql-test/t/grant.test	2005-11-28 12:28:37 +01:00
+++ 1.37/mysql-test/t/grant.test	2006-01-04 17:02:02 +01:00
@@ -500,3 +500,14 @@
 set names latin1;
 
 # End of 4.1 tests
+
+#
+# Bug #15598 Server crashes in specific case during setting new password
+#
+# Create a user with host "", will be stored in host table as NULL
+create user mysqltest_7@;
+set password for mysqltest_7@ = password('systpass');
+show grants for mysqltest_7@;
+drop user mysqltest_7@;
+--error 1141
+show grants for mysqltest_7@;
Thread
bk commit into 5.0 tree (msvensson:1.2009) BUG#15598msvensson4 Jan